Re: [PATCH 1/3] x86: Readd asmregparm

From: Ingo Molnar
Date: Wed Jun 08 2011 - 04:20:18 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> For a followon patchkit of mine I need to mark all functions
> that can be called from assembler. But on 32bit kernels some
> assembler functions are called with register arguments and others
> with stack arguments. asmlinkage forces stack arguments.
>
> This patch readds the recently removed asmregparm to be able
> to mark assembler functions called with register arguments on 32bit.
>
> Unlike the old code it's x86 only now to prevent it from
> leaking.
>
> Cc: x86@xxxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

That's a totally useless changelog (you are deliberately hiding
information again) so the series is obviously not acceptable.
Please fix and resend.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/