Re: [PATCH] x86: Fix sys_call_table type in asm/syscall.h

From: Ingo Molnar
Date: Wed Jun 08 2011 - 04:04:16 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Make the sys_call_table type defined in asm/syscall.h match
> the definition in syscall_64.c
>
> Cc: x86@xxxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
> arch/x86/include/asm/syscall.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
> index c4a348f..32295b7 100644
> --- a/arch/x86/include/asm/syscall.h
> +++ b/arch/x86/include/asm/syscall.h
> @@ -16,7 +16,8 @@
> #include <linux/sched.h>
> #include <linux/err.h>
>
> -extern const unsigned long sys_call_table[];
> +typedef void (*sys_call_ptr_t)(void);
> +extern const sys_call_ptr_t sys_call_table[];
>
> /*
> * Only the low 32 bits of orig_ax are meaningful, so we return int.

There's an obvious problem with this patch, please fix it and resend.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/