RE: spi_fsl_spi broken when compiled as module byb36ece832512c1a0afa54ff0a56d63492a1caf08

[Randy Dunlap]

On Sun, May 15, 2011 7:10 pm, Hu Mingkai-B21284 wrote:
> Hi len,
>
> You can prepare the patch using git tool and send it to the maillist.

Hi,

What do you mean by this?  In the past there has been no
requirement for individual patch submitters to use git
(whereas tree maintainers might be so required).

Are you implying that using git is required for some
kernel patches?

Thanks.


> Also add spi-devel-general@xxxxxxxxxxxxxxxxxxxxx maillist.
>
> Thanks,
> Mingkai
>
>> -----Original Message-----
>> From: Lennart Sorensen [mailto:lsorense@xxxxxxxxxxxxxxxxxxx]
>> Sent: Thursday, May 12, 2011 11:11 PM
>> To: Hu Mingkai-B21284
>> Cc: Lennart Sorensen; linux-kernel@xxxxxxxxxxxxxxx; Grant Likely; Kumar
>> Gala
>> Subject: Re: spi_fsl_spi broken when compiled as module by
>> b36ece832512c1a0afa54ff0a56d63492a1caf08
>>
>> On Thu, May 12, 2011 at 01:33:55AM +0000, Hu Mingkai-B21284 wrote:
>> > Please submit a patch to modify it.
>>
>> OK.  Here it is.
>>
>> --
>> Len Sorensen
>>
>> Add missing exports and module license to allow compiling of spi_fsl_*
>> drivers as modules again.  Originally broken by refactoring of code in
>> b36ece832512c1a0afa54ff0a56d63492a1caf08.
>>
>> diff --git a/drivers/spi/spi_fsl_lib.c b/drivers/spi/spi_fsl_lib.c index
>> ff59f42..d7efaac 100644
>> --- a/drivers/spi/spi_fsl_lib.c
>> +++ b/drivers/spi/spi_fsl_lib.c
>> @@ -48,16 +48,23 @@ u32 mpc8xxx_spi_tx_buf_##type(struct mpc8xxx_spi
>> *mpc8xxx_spi)	\
>>  }
>>
>>  MPC8XXX_SPI_RX_BUF(u8)
>> +EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u8);
>>  MPC8XXX_SPI_RX_BUF(u16)
>> +EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u16);
>>  MPC8XXX_SPI_RX_BUF(u32)
>> +EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u32);
>>  MPC8XXX_SPI_TX_BUF(u8)
>> +EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u8);
>>  MPC8XXX_SPI_TX_BUF(u16)
>> +EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u16);
>>  MPC8XXX_SPI_TX_BUF(u32)
>> +EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u32);
>>
>>  struct mpc8xxx_spi_probe_info *to_of_pinfo(struct fsl_spi_platform_data
>> *pdata)  {
>>  	return container_of(pdata, struct mpc8xxx_spi_probe_info, pdata);  }
>> +EXPORT_SYMBOL(to_of_pinfo);
>>
>>  void mpc8xxx_spi_work(struct work_struct *work)  { @@ -116,6 +123,7 @@
>> const char *mpc8xxx_spi_strmode(unsigned int flags)
>>  	}
>>  	return "CPU";
>>  }
>> +EXPORT_SYMBOL(mpc8xxx_spi_strmode);
>>
>>  int mpc8xxx_spi_probe(struct device *dev, struct resource *mem,
>>  			unsigned int irq)
>> @@ -168,6 +176,7 @@ int mpc8xxx_spi_probe(struct device *dev, struct
>> resource *mem,
>>  err:
>>  	return ret;
>>  }
>> +EXPORT_SYMBOL(mpc8xxx_spi_probe);
>>
>>  int __devexit mpc8xxx_spi_remove(struct device *dev)  { @@ -188,6
>> +197,7
>> @@ int __devexit mpc8xxx_spi_remove(struct device *dev)
>>
>>  	return 0;
>>  }
>> +EXPORT_SYMBOL(mpc8xxx_spi_remove);
>>
>>  int __devinit of_mpc8xxx_spi_probe(struct platform_device *ofdev)  { @@
>> -
>> 234,3 +244,8 @@ err:
>>  	kfree(pinfo);
>>  	return ret;
>>  }
>> +EXPORT_SYMBOL(of_mpc8xxx_spi_probe);
>> +
>> +MODULE_AUTHOR("Kumar Gala");
>> +MODULE_DESCRIPTION("Freescale SPI/eSPI controller driver library");
>> +MODULE_LICENSE("GPL");
>
>
> --


-- 
~Randy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/