Re: [PATCH 4/5] Add a sysconf syscall

[Ingo Molnar]

* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> During testing we found some cases where a library wants to know
> the number of CPUs for internal tuning, and calls sysconf for that.
> glibc then reads /proc/stat which is very slow and scales poorly,
> when the program is executed often.
> 
> For example sleepycat DB has this problem.
> 
> This patch adds a sysconf system call to avoid this problem.
> This adds very little code to the kernel, but gives a large speedup.
> 
> It is intended to be called from glibc.
> 
> It is not a 100% POSIX sysconf -- some values in there are only
> known to the C library, but supplies all values usefully
> known to the kernel.
> 
> In some cases it is more accurate than glibc can do because it doesn't
> have to guess. So when some value changes in the kernel it can
> return the current value.
> ---
>  include/linux/sysconf.h |   23 ++++++++++++++
>  kernel/Makefile         |    2 +-
>  kernel/sysconf.c        |   77 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 101 insertions(+), 1 deletions(-)
>  create mode 100644 include/linux/sysconf.h
>  create mode 100644 kernel/sysconf.c

What glibc does (opening /proc/stat) is rather stupid, but i think your syscall 
is just as stupid a solution as well, you are just implementing a weird 
filesystem, and a pretty slow one at that.

Note that these are mostly constant or semi-constant values that are updated 
very rarely:

+#define _SC_ARG_MAX     	0
+#define _SC_CHILD_MAX          1
+#define _SC_CLK_TCK            2
+#define _SC_NGROUPS_MAX        3
+#define _SC_OPEN_MAX           4
+#define _SC_PAGESIZE           30
+#define _SC_SEM_NSEMS_MAX      32
+#define _SC_SIGQUEUE_MAX       34
+#define _SC_UIO_MAXIOV         60
+#define _SC_NPROCESSORS_CONF   83
+#define _SC_NPROCESSORS_ONLN   84
+#define _SC_PHYS_PAGES         85
+#define _SC_AVPHYS_PAGES	86
+#define _SC_SYMLOOP_MAX	173

If glibc is stupid and reads /proc/stat to receive something it could cache or 
mmap() itself then hey, did you consider fixing glibc or creating a sane libc? 
It's open-source.

Do not help glibc remain stupid and sloppy until eternity!

If we *really* want to offer kernel help for these values even then your 
solution is still wrong: then the proper solution would be to define a standard 
*data* structure and map it as a vsyscall *data* page - essentially a 
kernel-guaranteed data mmap(), with no extra syscall needed!

That could have other uses as well in the future.

That way it would much faster than your current code btw.

So unless there are some compelling arguments in favor of sys_sysconf() that i 
missed, i have to NAK this:

Nacked-by: Ingo Molnar <mingo@xxxxxxx>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/