Re: [PATCH] platform: fix samsung brightness min/max calculations

[Jason Stubbs]

On Fri, 13 May 2011 02:44:02 Greg KH wrote:
> On Thu, May 12, 2011 at 12:13:59PM +1000, Jason Stubbs wrote:
> > On Wed, 11 May 2011 23:51:14 Greg KH wrote:
> > > On Wed, May 11, 2011 at 02:47:49PM +1000, Jason Stubbs wrote:
> > > > The patch doesn't apply cleanly on top of the nc210/nc110 patch
> > > > though as they both modify set_brightness(). It might apply with a
> > > > higher fuzz factor as the changes don't actually clash. Should I
> > > > redo the patch?
> > > 
> > > Please do.
> > 
> > Will send seperately. Doing this though, I found a problem with the
> > nc210/nc110 patch in that (user_level == read_brightness()) check should
> > actually be (user_brightness == read_brightness()). What should I do
> > about this?
> 
> I don't know, as you seem to understand this better than I do at this
> point, I'll trust your changes :)

I meant that patch A is broken but (working) patch B applies on top of patch
A so should I submit a patch C to fix patch A, submit a fixed patch A and
then resubmit a patch B against that, or... I'm just unsure of the
development process.

As far as I can tell, the patches aren't applied to any trees yet and are
just sitting in .../gregkh/patches.git. If that's the case, what I would like
is for fix-samsung-brightness-min-max-calculations.patch to be replaced with
the version in https://lkml.org/lkml/2011/4/20/1 and I resubmit a fixed (and
enhanced) add-support-for-samsung-nc210-nc110.patch that applies on top of
it. That way an enhancement patch won't hold up a bugfix patch should there
be any further issues.

I actually wasn't particularly happy with the nc210-n110 patch and was hoping
for some guidance but I think I've managed to implement the workaround
cleanly now so I'll post it in a sec. If you take it and the 2011/4/20/1 one,
great! Otherwise, please let me know what to do. (and sorry for the bother!)

Regards,
Jason Stubbs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/