Re: [PATCH 2/4] oom: kill younger process first

From: KOSAKI Motohiro
Date: Fri May 13 2011 - 06:14:17 EST


(2011/05/11 8:31), David Rientjes wrote:
On Tue, 10 May 2011, KOSAKI Motohiro wrote:

This patch introduces do_each_thread_reverse() and
select_bad_process() uses it. The benefits are two,
1) oom-killer can kill younger process than older if
they have a same oom score. Usually younger process
is less important. 2) younger task often have PF_EXITING
because shell script makes a lot of short lived processes.
Reverse order search can detect it faster.


I like this change, thanks! I'm suprised we haven't needed a
do_each_thread_reverse() in the past somewhere else in the kernel.

Could you update the comment about do_each_thread() not being break-safe
in the second version, though?

ok.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/