Re: [patch]: Coding style changes for Staging sm7xx

[Greg KH]

On Thu, May 12, 2011 at 12:11:34AM +0530, anish wrote:
> Hi Greg,
> 
> This patch is for staging sm7xx 
> (Silicon Motion SM7XX frame buffer device).
> Patch contains some coding style changes.
> 
> I have compiled and built it against linus tree.

You should always do this against the linux-next tree, otherwise it
probably will not apply due to the few hundred pending patches already
queued up for the next merge window.

Please redo it against the linux-next tree and resend with the below
changes as well.

> Please find the patch as attachment and checked with checkpatch.
> 
> ps:this is my first patch for linux kernel.
> Regards,
> anish

> >From 1c66ca66cf230dfa610fc1a899c45f4ac3cb6070 Mon Sep 17 00:00:00 2001
> From: anish kumar <anish198519851985@xxxxxxxxx>

Please don't attach patches, include them as the whole email.

> Date: Wed, 11 May 2011 23:12:53 +0530
> Subject: [PATCH 1/2] Coding style changes to align with linux

Please be more descriptive, what does this mean?

Also, where is patch 2/2?

> Signed-off-by: anish<anish198519851985@xxxxxxxxx>

I need a real, and full, name here.

As for the patch itself, you are doing a lot of different "cleanups"
here, please split them out into one-type-of-cleanup-per-patch and
resend them as multiple patches.

hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/