Re: [RFC PATCH] perf: Carve out cgroup-related code

From: Ingo Molnar
Date: Wed May 11 2011 - 13:30:23 EST



* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> On Wed, 2011-05-11 at 14:11 +0200, Borislav Petkov wrote:
> > include/linux/perf_event.h | 138 ++++++++++++-
>
> I don't like exposing all that in a kernel wide header.. should we maybe
> have kernel/events/internal.h?

Yeah.

We could eventually avoid exposing much of struct perf_event as well: arch PMU
drivers need the struct perf_event_attr, struct hw_perf_event and not much
else.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/