Re: [RFC][PATCH] pstore: EFI Support

From: AmÃrico Wang
Date: Wed May 11 2011 - 11:57:39 EST


On Wed, May 11, 2011 at 12:11 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Tue, May 10, 2011 at 11:00:44AM -0400, Seiji Aguchi wrote:
>> Description of boot paremeters is following.
>>
>> Â- efi_pstore_enable
>> Â Âenable EFI support of pstore.
>>
>> Â- efi_pstore_len
>> Â ÂSets the buffer size of EFI variable space used by pstore.
>
> Please don't add new boot parameters if at all possible. ÂDistros will
> not know to enable them, and users don't know how to either.
>
> Use sane defaults, and provide ways to override them if needed, but
> don't rely on them for new functionality if at all possible.

I agree. It seems that we should enable this by default when APEI and
EFI are both enabled, this could be done by Kconfig.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/