Re: 2.6.39-rc6-mmotm0506 - another lockdep splat (networking thistime)

From: David Miller
Date: Tue May 10 2011 - 17:59:44 EST


From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Tue, 10 May 2011 23:48:36 +0200

> Le lundi 09 mai 2011 à 20:58 -0700, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>> Date: Tue, 10 May 2011 05:47:51 +0200
>>
>> > [PATCH net-next-2.6] net: fix two lockdep splats
>> >
>> > Commit e67f88dd12f6 (net: dont hold rtnl mutex during netlink dump
>> > callbacks) switched rtnl protection to RCU, but we forgot to adjust two
>> > rcu_dereference() lockdep annotations :
>> >
>> > inet_get_link_af_size() or inet_fill_link_af() might be called with
>> > rcu_read_lock or rtnl held, so use rcu_dereference_rtnl()
>> > instead of rtnl_dereference()
>> >
>> > Reported-by: Valdis Kletnieks <Valdis.Kletnieks@xxxxxx>
>> > Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>>
>> Applied, thanks everyone.
>
> David, I found you applied this patch for net-2.6, but it was
> net-next-2.6 material only ...

Thanks for catching that, I'll fix this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/