Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses

[OGAWA Hirofumi]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> On Wed, May 11, 2011 at 12:24:58AM +0900, OGAWA Hirofumi wrote:
>> > under writeback and when it's freed no writeback is started.
>> 
>> Sure for data -> data reallocated case. metadata -> data/metadata is
>> still there.
>
> That's usually handled differently.  For XFS take a look at the
> xfs_alloc_busy_* function.  For 2.6.40 they've been mostly rewritten
> to rarely wait for the reuse but instead avoid busy blocks.  But that's
> a real data integrity issue even without stable pages for I/O.

Sounds good. So... Are you suggesting this series should use better
approach than just blocking?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/