Re: [RFC][PATCH 0/3] perf support for amd guest/host-only bits

[Roedel, Joerg]

On Tue, May 10, 2011 at 11:21:32AM -0400, Ingo Molnar wrote:
> 
> * Joerg Roedel <joerg.roedel@xxxxxxx> wrote:
> 
> > So any feedback is greatly appreciated :-)
> 
> it's nice to see this hw feature utilized :)

Yeah, I planned to do this for some time now and finally found the time
to do it :)

> 
> > Diffstat:
> > 
> >  arch/x86/include/asm/perf_event.h    |    3 +++
> >  arch/x86/kernel/cpu/perf_event_amd.c |    6 ++++++
> >  include/linux/perf_event.h           |    5 ++++-
> >  kernel/perf_event.c                  |    4 ++++
> >  tools/perf/util/parse-events.c       |   10 +++++++++-
> >  5 files changed, 26 insertions(+), 2 deletions(-)
> 
> I see you have not touched tools/perf/builtin-kvm.c - how does this feature 
> integrate with the features of 'perf kvm'? (are you using perf kvm by any 
> chance?)

builtin-kvm looks like a wrapper for other perf-cmds which just sets up
some additional state to tell the sub-cmds that guest-symbols need to be
resolved and so on.
Implementing this into the place where the other exclude-bits get set
(which is in generic code) seemed like a good idea to me. Touching
builtin-kvm was unnecessary for this.

Regards,

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/