Re: [PATCH v3 5/6] x86-64: Move vread_tsc into a new file withsensible options

[Peter Zijlstra]

On Tue, 2011-05-10 at 10:15 -0400, Andy Lutomirski wrote:
> vread_tsc is short and hot, and it's userspace code so the usual
> reasons to keep frame pointers around, enable -pg, and turn off
> sibling calls don't apply.
> 
I really don't like that, turning off frame pointers here means that if
your profiler interrupt hits while in the vDSO the user-space backtrace
is dead.

Please leave the frame pointer in. Esp on x86_64 the cost of keeping the
framepointer isn't much at all since it isn't nearly as register starved
as i386.

I'm fine with stripping -pg, that is indeed useless for the vDSO.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/