Re: [PATCHv1 -next] WATCHDOG: Watchdog module of DA9052 devicedriver

[Wim Van Sebroeck]

Hi Ashish, David,

Driver looks OK at first glance. Will look at it some more later this week.

> +static int __devexit da9052_sm_remove(struct platform_device *dev)
> +{
> +       misc_deregister(&da9052_wdt_miscdev);
> +       strobe_interval = 0;
> +       strobe_mode = 0;
> +       return 0;
> +}

Small remark: here I am missing a kfree(wdt);

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/