Re: [PATCH resend] s390: oprofile: fix error checks inoprofile_hwsampler_init()

From: Martin Schwidefsky
Date: Tue May 10 2011 - 05:19:52 EST


On Tue, 10 May 2011 11:00:54 +0200
Robert Richter <robert.richter@xxxxxxx> wrote:

> > Ok, the improved patch now looks like this:
> > --
> > Subject: [PATCH] s390: oprofile: fix min/max interval query checks
> >
> > From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> >
> > oprofile_min_interval and oprofile_max_interval are unsigned, checking
> > for negative values doesn't work. Change hwsampler_query_min_interval
> > and hwsampler_query_max_interval to return an unsigned long and
> > check for a zero value instead.
> >
> > Reported-by: Nicolas Kaiser <nikai@xxxxxxxxx>
> > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>
> Looks good.
>
> Acked-by: Robert Richter <robert.richter@xxxxxxx>
>
> Martin, can you queue this up?

Yes, I will do that.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/