Re: 2.6.39-rc6-mmotm0506 - lockdep splat in RCU code on page fault

[Ingo Molnar]

* Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:

> -	raw_spin_lock_irqsave(&rnp->lock, flags);
> -	rnp->wakemask |= rdp->grpmask;
> -	raw_spin_unlock_irqrestore(&rnp->lock, flags);
> +	do {
> +		old = rnp->wakemask;
> +		new = old | rdp->grpmask;
> +	} while (cmpxchg(&rnp->wakemask, old, new) != old);

Hm, isnt this an inferior version of atomic_or_long() in essence?

Note that atomic_or_long() is x86 only, so a generic one would have to be 
offered too i suspect, atomic_cmpxchg() driven or so - which would look like 
the above loop.

Most architectures could offer atomic_or_long() i suspect.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/