Re: [PATCH 12/19] mfd: Use mfd cell platform_data for wm8400 cellsplatform bits

[Samuel Ortiz]

Hi Mark,

On Mon, May 09, 2011 at 09:13:42AM +0200, Mark Brown wrote:
> On Mon, May 09, 2011 at 02:32:04AM +0200, Samuel Ortiz wrote:
> 
> >  static int wm8400_codec_probe(struct snd_soc_codec *codec)
> >  {
> > -	struct wm8400 *wm8400 = mfd_get_data(to_platform_device(codec->dev));
> > +	struct wm8400 *wm8400 = codec->dev->platform_data;
> 
> It'd be better to use platform_get_drvdata() here rather than accessing
> the pointer directly.
Is the core codec code setting the driver_data pointer appropriately ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/