Re: [PATCH 10/14] HPFS: Implement fsync for hpfs

From: Christoph Hellwig
Date: Tue May 10 2011 - 04:04:00 EST


On Sun, May 08, 2011 at 08:44:19PM +0200, Mikulas Patocka wrote:
> Index: linux-2.6.39-rc5-fast/fs/hpfs/file.c
> ===================================================================
> --- linux-2.6.39-rc5-fast.orig/fs/hpfs/file.c 2011-05-05 01:02:43.000000000 +0200
> +++ linux-2.6.39-rc5-fast/fs/hpfs/file.c 2011-05-05 01:02:56.000000000 +0200
> @@ -20,8 +20,8 @@ static int hpfs_file_release(struct inod
>
> int hpfs_file_fsync(struct file *file, int datasync)
> {
> - /*return file_fsync(file, datasync);*/
> - return 0; /* Don't fsync :-) */
> + struct inode *inode = file->f_mapping->host;
> + return sync_blockdev(inode->i_sb->s_bdev);

So you push all dirty data into buffers immediately and don't have
anything else to write back?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/