Please don't hijack patches - even trivial ones (was: Re: [PATCH13/14] HPFS: Move declaration up, so that there are no out-of-scopepointers=
From: Jesper Juhl
Date: Mon May 09 2011 - 16:29:01 EST
On Sun, 8 May 2011, Mikulas Patocka wrote:
> Move declaration up, so that there are no out-of-scope pointers
>
> Reported-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> Signed-off-by: Mikulas Patocka <mikulas@xxxxxxxxxxxxxxxxxxxxxxxx>
>
Hmm. I'm a little currious how my original Signed-off-by got turned into a
Reported-by for this patch?
This patch is *exactely* the one I submitted on Dec 24 in a message with
Message-ID: <alpine.LNX.2.00.1012242020090.28973@xxxxxxxxxxxxxxxxxxxxxxxxx>
Ok, it's a trivial little thing, but still. When the patch is completely
unchanged I think it's a little steep to change the original authors
Signed-off-by and essentially claim authorship of the patch for one self.
> ---
> fs/hpfs/ea.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.39-rc5-fast/fs/hpfs/ea.c
> ===================================================================
> --- linux-2.6.39-rc5-fast.orig/fs/hpfs/ea.c 2011-05-05 01:03:00.000000000 +0200
> +++ linux-2.6.39-rc5-fast/fs/hpfs/ea.c 2011-05-05 01:03:01.000000000 +0200
> @@ -76,6 +76,7 @@ int hpfs_read_ea(struct super_block *s,
> unsigned pos;
> int ano, len;
> secno a;
> + char ex[4 + 255 + 1 + 8];
> struct extended_attribute *ea;
> struct extended_attribute *ea_end = fnode_end_ea(fnode);
> for (ea = fnode_ea(fnode); ea < ea_end; ea = next_ea(ea))
> @@ -93,7 +94,6 @@ int hpfs_read_ea(struct super_block *s,
> ano = fnode->ea_anode;
> pos = 0;
> while (pos < len) {
> - char ex[4 + 255 + 1 + 8];
> ea = (struct extended_attribute *)ex;
> if (pos + 4 > len) {
> hpfs_error(s, "EAs don't end correctly, %s %08x, len %08x",
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/