Re: [PATCH 04/11] ptrace: implement PTRACE_INTERRUPT

[Tejun Heo]

Hello,

On Sun, May 08, 2011 at 11:58:20PM +0200, Denys Vlasenko wrote:
> Are rules for PTRACE_INTERRUPT the same? That is, what happens
> if a different trap is taken?

Oh, PTRACE_INTERRUPT is different.  If it's scheduled, it will
eventually happen.  Other traps may happen before but INTERRUPT trap
will take place before control is returned to userland.

> Can you add API notes in the header, above corresponding defines? -
> 
> --- a/include/linux/ptrace.h
> +++ b/include/linux/ptrace.h
> @@ -48,6 +48,7 @@
>  #define PTRACE_SETREGSET       0x4205
>  
> <============================================ ADD COMMENT HERE
>  #define PTRACE_SEIZE           0x4206
> <============================================ ADD COMMENT HERE
> +#define PTRACE_INTERRUPT       0x4207
> 
> 
> They will be much more visible and up-to-date there than in Documentation,
> git logs etc...

Hmmm... I was thinking about writing a proper ptrace API doc with
example programs under Documentation/.  It's userland visible API so
it shouldn't change all that much and the amount of necessary
documentation would be too much for comments.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/