Re: [PATCH 3/4] EDAC, MCE, AMD: Add hw_inject and cpu sysfs attrs

From: Borislav Petkov
Date: Sun May 08 2011 - 14:49:47 EST


On Sun, May 08, 2011 at 12:40:54PM -0400, Greg KH wrote:
> On Thu, May 05, 2011 at 06:49:35PM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <borislav.petkov@xxxxxxx>
> >
> > Add sysfs handlers for the 'hw_inject' and 'cpu' attrs.
>
> You forgot to add the proper Documentation/ABI/ files for these new
> sysfs files. Please do that.

Yeah, so those sprang up as a testing module and the final goal is to
have all injection done through perf events but it could also be prudent
to keep those as a fallback alternative.

I'm thinking something like
Documentation/ABI/testing/sysfs-devices-system-edac but looking
at Documentation/ABI/README and reading the "testing/" category
description, I don't think it applies to those interfaces just yet for
the simple reason that they're still changing and I wouldn't want to
cast them in stone now.

Can we add them to a "unstable" category instead or maybe delay making
the ABI description for now?

Thanks.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/