Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA busdriver

From: Russell King - ARM Linux
Date: Sun May 08 2011 - 06:17:34 EST


On Sat, May 07, 2011 at 08:48:10PM +0200, RafaÅ MiÅecki wrote:
> Really, what's wrong with that? Does it kill anyone's pet we print
> this? We also do:
> pr_err("Scanning failed because of wrong CID\n");
> return -1;
> While we could drop pr_err. Why to do this? Advanced used can always
> check what -1 means.

And why return -1 when we have a system of error codes? I _really_ wish
people would stop returning -1 for "some random error occurred".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/