Re: [PATCH 2/2] writeback: elevate queue_io() into wb_writeback()

[Wu Fengguang]

On Wed, May 04, 2011 at 07:08:49PM +0800, Christoph Hellwig wrote:
> >  	return 1;
> >  }
> >  
> > -void writeback_inodes_wb(struct bdi_writeback *wb,
> > -		struct writeback_control *wbc)
> > +static void __writeback_inodes_wb(struct bdi_writeback *wb,
> > +				  struct writeback_control *wbc)
> >  {
> >  	int ret = 0;
> >  
> >  	if (!wbc->wb_start)
> >  		wbc->wb_start = jiffies; /* livelock avoidance */
> 
> This should move to writeback_inodes_wb and be unconditional as
> wb_writeback already always initializes it.

Never mind :) wbc->wb_start has been killed in a later patch named
"writeback: avoid extra sync work at enqueue time".

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/