Re: [PATCH] drivers: brcmaxi: provide amba axi functionality inseparate module

From: Arend van Spriel
Date: Sat Apr 23 2011 - 11:08:13 EST


On Sat, 23 Apr 2011 14:33:21 +0200, Jonas Gorski <jonas.gorski@xxxxxxxxx> wrote:

On 21 April 2011 16:38, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
Would it be possible to make chipcommon driver optional (not doing the
initialization)?

This would need to be done on a per-device/bus basis, at least for
embedded. Consider the following setup (which is quite common for dual
band routers):

BCM4718 (bus A)
+- MIPS74k
+- Common Core <- provides flash write access, GPIOs, watchdog, ...
+- 802.11 Core <- for 2.4Ghz wifi
+- PCIe Core
+ BCM43224 (bus B)
+- Common Core
+- 802.11 Core <- for 5Ghz wifi

(I omitted any cores not relevant for the example)

The MIPS may be relevant as well ;-)

In the example above I would expect two axi bus driver instances for bus A and bus B.

So eventually you want to able to drive both 802.11 cores, but can't
exclusively claim both common cores.

I would expect to be probed twice. One call for 2.4GHz 802.11 core referencing to bus A and one call for 5GHz 802.11 core referencing to bus B.

Regarding chipcommon I agree that it requires one init sequence per device. I would just like to have the option to provide a custom initialization function for chip common (and possibly pcie) somehow.

Gr. AvS
--
"The world is indeed comic, but the joke is on mankind." â H.P. Lovecraft

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/