Re: [PATCH 05/10] block: remove per-queue plugging

From: hch@xxxxxxxxxxxxx
Date: Fri Apr 22 2011 - 11:39:25 EST


On Mon, Apr 18, 2011 at 05:23:06PM -0400, hch@xxxxxxxxxxxxx wrote:
> > NeilBrown (6):
> > md: use new plugging interface for RAID IO.
> > md/dm - remove remains of plug_fn callback.
> > md - remove old plugging code.
> > md: provide generic support for handling unplug callbacks.
> > md: incorporate new plugging into raid5.
> > md: fix up raid1/raid10 unplugging.
>
> Looking over more of the unplugging left over, is there a reason to
> keep the unplug_work bits in CFQ? They seem to rather counter the
> current scheme (and it is the last user of kblockd outside of
> blk-core.c)

Jens, Vivkek:

can you take a look at if cfq_schedule_dispatch is still needed in
new unplugging world order? It's the only kblockd user outside the
block core that's still left, and it seems rather odd to me at least.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/