Re: [Xen-devel] Re: [PATCH] xen block backend driver.

From: Christoph Hellwig
Date: Fri Apr 22 2011 - 05:09:49 EST


On Thu, Apr 21, 2011 at 12:14:37PM -0700, Daniel Stodden wrote:
> > There is a huge userbase of guests out there that does rely on it.
>
> Which ones? Old blkfront would have make a difference back then when
> barriers used to be an option, but it never actually declared it, right?

Pre-Linux 2.6.37 guests using reiserfs actually relied on the queue
flushing. This includes a lot of SLES installation which are still
in common use. There's only two options to make sure they work:

(1) keep the original barrier semantics and flush the queue
(2) do not advertize "barrier" support at all, and make sure to submit
every I/O we get with the FUA bit.

In practice (2) is going to be faster for most real-life workloads. So
maybe you should just drop the old "barrier" support and just send
requests with the FUA bit set for now, until you have proper flush
and fua support in the protocol.

> Weeeeeelll, I certainly hope it can deal with backends which never got
> to see those headers. :o)

They probably try to handle it, no idea how correct the handling is
in the end.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/