Re: [PATCH 1/4] perf, x86: P4 PMU -- Use perf_sample_data_init helper

[Cyrill Gorcunov]

yeah, it can wait

On Friday, April 22, 2011, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Don Zickus <dzickus@xxxxxxxxxx> wrote:
>
>> From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
>>
>> Instead of opencoded assignments better to use
>> perf_sample_data_init helper.
>>
>> Tested-by: Lin Ming <ming.m.lin@xxxxxxxxx>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
>> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
>> ---
>>  arch/x86/kernel/cpu/perf_event_p4.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
>> index c2520e1..6f2bd89 100644
>> --- a/arch/x86/kernel/cpu/perf_event_p4.c
>> +++ b/arch/x86/kernel/cpu/perf_event_p4.c
>> @@ -912,8 +912,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs)
>>       int idx, handled = 0;
>>       u64 val;
>>
>> -     data.addr = 0;
>> -     data.raw = NULL;
>> +     perf_sample_data_init(&data, 0);
>
> This one sure can wait for v2.6.40, right?
>
> Thanks,
>
>         Ingo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/