Re: [PATCH] block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers

From: Jens Axboe
Date: Thu Apr 21 2011 - 15:31:48 EST


On 2011-04-21 21:00, Tejun Heo wrote:
> In-kernel disk event polling doesn't matter for legacy/fringe drivers
> and may lead to infinite event loop if ->check_events() implementation
> generates events on level condition instead of edge.
>
> Now that block layer supports suppressing exporting unlisted events,
> simply leaving disk->events cleared allows these drivers to keep the
> internal revalidation behavior intact while avoiding weird
> interactions with userland event handler.

Seems like the good thing to do, I'll queue this up for 2.6.39.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/