Re: [PATCH 1/2] x86, MCE: Do not taint when handling correctableerrors

[Ingo Molnar]

* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Thu, Apr 21, 2011 at 05:35:54AM -0400, Ingo Molnar wrote:
> > 
> > * Chumbalkar, Nagananda <Nagananda.Chumbalkar@xxxxxx> wrote:
> > 
> > > Would it be okay to extend this reasoning and also remove the tainting 
> > > caused by TM1/TM2 thermal events:
> > > 
> > > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > > b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > > index 6f8c5e9..9f3b5ae 100644
> > > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > > @@ -188,7 +188,6 @@ static int therm_throt_process(bool new_event, int event,
> > > int level)
> > >                                 level == CORE_LEVEL ? "Core" : "Package",
> > >                                 state->count);
> > > 
> > > -               add_taint(TAINT_MACHINE_CHECK);
> > >                 return 1;
> > >         }
> > >         if (old_event) {
> > > @@ -393,7 +392,6 @@ static void unexpected_thermal_interrupt(void)
> > > {
> > >         printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> > >                         smp_processor_id());
> > > -       add_taint(TAINT_MACHINE_CHECK);
> > > }
> > 
> > Mind sending a proper patch, with changelog, signoff, acks, etc?
> 
> No need since this is part of 7b70bd3441437b7bc04fc9d321e17c8ed0e8f958
> now which is in tip/x86/mce.

Ok, indeed. Also, in the future, if you take patches from others please also 
credit them in the changelog. Something like this would have been good in the 
current case:

  Also, this patch includes a change from Nagananda Chumbalkar as well, which 
  drops tainting in the therma throttling code for a similar reason: crossing a
  thermal threshold does not mean corruption.

Nagananda's Acked-by is there so there's at least partial credit - but we 
generally try to aim for at least 100% credit where credit is due :-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/