Re: [PATCH v3] mm: make expand_downwards symmetrical toexpand_upwards

From: James Bottomley
Date: Wed Apr 20 2011 - 18:15:40 EST


On Wed, 2011-04-20 at 14:18 -0700, David Rientjes wrote:
> This is probably because the parisc's DISCONTIGMEM memory ranges don't
> have bits set in N_NORMAL_MEMORY.
>
> diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
> --- a/arch/parisc/mm/init.c
> +++ b/arch/parisc/mm/init.c
> @@ -266,8 +266,10 @@ static void __init setup_bootmem(void)
> }
> memset(pfnnid_map, 0xff, sizeof(pfnnid_map));
>
> - for (i = 0; i < npmem_ranges; i++)
> + for (i = 0; i < npmem_ranges; i++) {
> + node_set_state(i, N_NORMAL_MEMORY);
> node_set_online(i);
> + }
> #endif

Yes, this seems to be the missing piece that gets it to boot. We really
need this in generic code, unless someone wants to run through all the
other arch's doing it ...

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/