Re: [PATCH 1/2] gpio: add pin biasing and drive mode to gpiolib

[Linus Walleij]

2011/4/19 Kyungmin Park <kmpark@xxxxxxxxxxxxx>:

> One more consideration, not mentioned previous time, is that pin
> configuration for power down mode.
> Samsung SoCs has retention GPIO configurations at sleep (suspend)
> mode. and restore it at resume time.
> it's need to reduce power and proper operation after suspend.

Isn't this supposed to be handled by runtime_pm hooks inside
your GPIO driver rather than by someone else talking to
the GPIO driver trying to spool/unspool the state from the
outside in some other place?

Or am I getting things backwards now...?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/