Re: [PATCH] tty/serial: add support for Xilinx PS UART

From: Greg KH
Date: Tue Apr 19 2011 - 19:22:19 EST


On Tue, Apr 19, 2011 at 04:22:00PM -0600, John Linn wrote:
> > -----Original Message-----
> > From: Alan Cox [mailto:alan@xxxxxxxxxxxxxxxxxxx]
> > Sent: Tuesday, April 19, 2011 3:16 PM
> > To: John Linn
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH] tty/serial: add support for Xilinx PS UART
> >
> > On Tue, 19 Apr 2011 14:14:52 -0600
> > John Linn <john.linn@xxxxxxxxxx> wrote:
> >
> > > The Xilinx PS Uart is used on the new ARM based SoC. This
> > > UART is not compatible with others such that a seperate
> > > driver is required.
> >
> > Joyous. I wish people would standardise.
> >
> > > + 213 = /dev/ttyPS0 Xilinx PS serial port 0
> > > + 214 = /dev/ttyPS1 Xilinx PS serial port 1
> > > + 215 = /dev/ttyPS2 Xilinx PS serial port 2
> > > + 216 = /dev/ttyPS3 Xilinx PS serial port 3
> >
> > Is there a specific reason you need fixed minor numbers ? If not
> please
> > use a dynamic range and keep Linus happy.
>
> Hi Alan,
>
> I hope you don't mind me asking a bit more to better understand. Here's
> my
> concerns (maybe not valid).
>
> It seems like since this is a console it can get hard to debug with
> dynamic
> nodes for this driver.
>
> This driver is for an embedded device where we don't want to require
> udev
> or mdev to assign nodes.

Why not use devtmpfs? There's no need to use udev or mdev at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/