Re: 2.6.39-rc3-gitX compiling errors of olpc-dcon_xo_1 and i82975x-edac

From: Randy Dunlap
Date: Mon Apr 18 2011 - 17:57:06 EST


On 04/18/11 14:49, werner wrote:
> =============================
>
> CC [M] drivers/staging/olpc_dcon/olpc_dcon_xo_1.o
> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c: In function 'dcon_wiggle_xo_1':
> drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:168: error: implicit
> declaration of function 'udelay'
>

Andrew has merged a patch for this one into his MM tree.
I'm attaching it below.

>
> CC [M] drivers/edac/i82975x_edac.o
> drivers/edac/i82975x_edac.c: In function 'i82975x_process_error_info':
> drivers/edac/i82975x_edac.c:298: warning: integer constant is too large
> for 'unsigned long' type

warning, not error.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Fix build error, needs delay.h:

drivers/staging/olpc_dcon/olpc_dcon_xo_1.c:168: error: implicit declaration of function 'udelay'

Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Cc: Andres Salomon <dilinger@xxxxxxxxxx>
---
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 1 +
1 file changed, 1 insertion(+)

Can we get something in MAINTAINERS for OLPC, please?

--- mmotm-2011-0331-1448.orig/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
+++ mmotm-2011-0331-1448/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c
@@ -11,6 +11,7 @@
* License as published by the Free Software Foundation.
*/
#include <linux/cs5535.h>
+#include <linux/delay.h>
#include <linux/gpio.h>
#include <asm/olpc.h>