Re: [PATCH] block: add blk_run_queue_async

From: Christoph Hellwig
Date: Mon Apr 18 2011 - 15:59:39 EST


On Mon, Apr 18, 2011 at 03:55:04PM -0400, Mike Snitzer wrote:
> > +{
> > + ? ? ? if (likely(!blk_queue_stopped(q)))
> > + ? ? ? ? ? ? ? queue_delayed_work(kblockd_workqueue, &q->delay_work, 0);
>
> I know Jens already queued this up 'for-linus' but why not use
> kblockd_schedule_work(q, &q->delay_work)?

I don't see what that would buy us. If we'd absolutely want a wrapper
a blk_delay_queue(q, 0) in Jens' current tree would do it now that is
has been fixed up to use the kblockd workqueue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/