Re: [PATCH 1/4] MIPS: Replace _PAGE_READ with _PAGE_NO_READ

From: David Daney
Date: Mon Apr 18 2011 - 13:33:04 EST


On 04/16/2011 09:44 AM, Kevin Cernekee wrote:
Reuse more of the same definitions for the non-RIXI and RIXI cases. This
avoids having special cases for kernel_uses_smartmips_rixi cluttering up
the pgtable*.h files.

On hardware that does not support RI/XI, EntryLo bits 31:30 / 63:62 will
remain unset and RI/XI permissions will not be enforced.

Signed-off-by: Kevin Cernekee<cernekee@xxxxxxxxx>
---
arch/mips/include/asm/pgtable-bits.h | 23 ++++++++---------------
arch/mips/include/asm/pgtable.h | 21 ++++++++-------------
arch/mips/mm/tlbex.c | 17 +++++------------
3 files changed, 21 insertions(+), 40 deletions(-)

[...]

I like this patch.

How much testing have you done on non-RI/XI CPUs?

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/