Re: [RFC][PATCH 3/7] lockdep: Annotate read/write states

[Steven Rostedt]

On Mon, 2011-04-18 at 21:34 +0800, Yong Zhang wrote:

> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > ---
> >  include/linux/lockdep.h |  107 ++++++++++++++++++++++++++++++++++++------------
> >  kernel/lockdep.c        |   46 ++++++++++----------
> >  2 files changed, 105 insertions(+), 48 deletions(-)
> > 
> > @@ -2273,7 +2273,7 @@ mark_held_locks(struct task_struct *curr
> >  		hlock = curr->held_locks + i;
> >  
> >  		usage_bit = 2 + (mark << 2); /* ENABLED */
> > -		if (hlock->read)
> > +		if (hlock->rw_state)
> 
> 		is_read(hlock->rw_state) ?

Yeah, I think this should be a is_read() or add a comment explaining why
not.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/