Re: [PATCH v3 2.6.39-rc1-tip 9/26] 9: uprobes: mmap and forkhooks.

From: Peter Zijlstra
Date: Mon Apr 18 2011 - 12:22:59 EST


On Fri, 2011-04-01 at 20:04 +0530, Srikar Dronamraju wrote:
> + if (vma) {
> + /*
> + * We get here from uprobe_mmap() -- the case where we
> + * are trying to copy an instruction from a page that's
> + * not yet in page cache.
> + *
> + * Read page in before copy.
> + */
> + struct file *filp = vma->vm_file;
> +
> + if (!filp)
> + return -EINVAL;
> + page_cache_sync_readahead(mapping, &filp->f_ra, filp, idx, 1);
> + }
> + page = grab_cache_page(mapping, idx);

So I don't see why that isn't so for the normal install_uprobe() <-
register_uprobe() path.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/