Re: [PATCH 2/2] mtd: msm_nand: Add initial msm nand driver support.

From: Artem Bityutskiy
Date: Sat Apr 16 2011 - 10:20:03 EST


> Can i export this variable now?

I do not think so, we do not export random variables.

> What is your suggestion?

But I already did provide you suggestions - kill this global variable
completely. I provided the reasons:

1. It is error prone to hide functions behind something which looks like
a constant.
2. Multiple controllers with different base addresses wouldn't work -
your driver has to be able to at least theoretically handle multiple
controllers with different bases.

--
Best Regards,
Artem Bityutskiy (ÐÐÑÑÑÐÐÐ ÐÑÑÑÐ)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/