Re: [PATCH tip:x86/mm] x86-64, NUMA: Remove custom phys_to_nid()implementation

From: Christoph Lameter
Date: Thu Mar 31 2011 - 10:31:11 EST


On Thu, 31 Mar 2011, Tejun Heo wrote:

> However, with SPARSE memory model, the nid is encoded in page flags.
> The perfect hash implementation was for DISCONTIG memory model which
> got removed years ago by b263295dbf (x86: 64-bit, make sparsemem
> vmemmap the only memory model).

Most memory models have the nid either in page flags or you can get it
from the zone that a page belongs to. So after boot its easy to
determine the node. However, at early boot the page flags may be
initialized relatively late. early_pfn_to_nid does use the early node map
to determine the node and not the page flags. You are switching to
the generic implementation of __pfn_to_nid and dropping the duplicate arch
logic.

Reviewed-by: Christoph Lameter <cl@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/