Re: [GIT PULL] block drivers for 2.6.39-rc

From: Ingo Molnar
Date: Mon Mar 28 2011 - 00:44:01 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Sun, Mar 27, 2011 at 9:23 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > This driver does not build at all:
> >
> > Âdrivers/block/drbd/drbd_bitmap.c:1187:5: error: implicit declaration of function âgeneric_find_next_zero_le_bitâ [-Werror=implicit-function-declaration]
> > Âdrivers/block/drbd/drbd_bitmap.c:1190:5: error: implicit declaration of function âgeneric_find_next_le_bitâ [-Werror=implicit-function-declaration]
> > Âdrivers/block/drbd/drbd_bitmap.c:1290:4: error: implicit declaration of function âgeneric___test_and_set_le_bitâ [-Werror=implicit-function-declaration]
> > Âdrivers/block/drbd/drbd_bitmap.c:1292:4: error: implicit declaration of function âgeneric___test_and_clear_le_bitâ [-Werror=implicit-function-declaration]
> > Âdrivers/block/drbd/drbd_bitmap.c:1441:3: error: implicit declaration of function âgeneric_test_le_bitâ [-Werror=implicit-function-declaration]
> >
> > Has this been build-tested? These APIs do not exist upstream.
>
> Actually, I think that's just a merge error - those horrible nasty
> crazy names did use to exist.

Yeah, indeed.

> Does this fix it? (Untested!)

It does, thanks!

Tested-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/