Re: [PATCH] drm/i915/lvds: Always return connected in the absence ofbetter information

[Alessandro Suardi]

On Thu, Mar 24, 2011 at 2:30 PM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> The LVDS connector should default to connected. We tried our best to
> verify the claims of the BIOS that the hardware exists during init(),
> and then during detect() we then try to verify that the panel is open.
> In the event of an unsucessful query, we should then always report
> that the LVDS panel is connected. This was only the case for gen3/4,
> later generations leaked the return value from the panel probe instead.
>
> Reported-by: Alessandro Suardi <alessandro.suardi@xxxxxxxxx>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

With this patch on top of 2.6.38-git14, I am back to 1440x900 by default.
Great work, thanks Chris ! FWIW, You can add my

Tested-by: Alessandro Suardi <alessandro.suardi@xxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/intel_lvds.c |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 1a311ad..86cd30b 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -473,19 +473,13 @@ static enum drm_connector_status
>  intel_lvds_detect(struct drm_connector *connector, bool force)
>  {
>        struct drm_device *dev = connector->dev;
> -       enum drm_connector_status status = connector_status_connected;
> +       enum drm_connector_status status;
>
>        status = intel_panel_detect(dev);
>        if (status != connector_status_unknown)
>                return status;
>
> -       /* ACPI lid methods were generally unreliable in this generation, so
> -        * don't even bother.
> -        */
> -       if (IS_GEN2(dev) || IS_GEN3(dev))
> -               return connector_status_connected;
> -
> -       return status;
> +       return connector_status_connected;
>  }
>
>  /**
> --
> 1.7.4.1
>
>

--alessandro

 "There's always a siren singing you to shipwreck"

   (Radiohead, "There There")
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/