Re: [PATCH] input/xen-fbfront: advertise either absolute or relativecoordinates

From: Dmitry Torokhov
Date: Sun Mar 13 2011 - 01:25:02 EST


Hi Stefano,

On Fri, Mar 11, 2011 at 11:30:10AM +0000, Stefano Stabellini wrote:
> From: Olaf Hering <olaf@xxxxxxxxx>
>
> A virtualized display device is usually viewed with the vncviewer
> application, either by 'xm vnc domU' or with vncviewer localhost:port.
> vncviewer and the RFB protocol provides absolute coordinates to the
> virtual display. These coordinates are either passed through to a PV
> guest or converted to relative coordinates for a HVM guest.
>
> A PV guest receives these coordinates and passes them to the kernels
> evdev driver. There it can be picked up by applications such as the
> xorg-input drivers. Using absolute coordinates avoids issues such as
> guest mouse pointer not tracking host mouse pointer due to wrong mouse
> acceleration settings in the guests X display.
>
> Advertise either absolute or relative coordinates to the input system
> and the evdev driver, depending on what dom0 provides. The xorg-input
> driver prefers relative coordinates even if a devices provides both.

So if I am reading this correctly the original version handled changes
in backend capabilities and could switch between delivering either
relative or absolute coordinates. The new version selects the
capabilities at boot time and sticks with them. Was it really the
intended behavior?

BTW, drivers/input is intended for core input and handlers stuff with
drivers suppsed to be in drivers/input/<type>. Would you mind if I moved
this driver to drivers/input/misc?

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/