Re: [PATCH] drm/i915: Revive combination mode for backlight control

From: Linus Torvalds
Date: Thu Mar 10 2011 - 20:29:28 EST


On Thu, Mar 10, 2011 at 5:23 PM, Indan Zupancic <indan@xxxxxx> wrote:
>
> After this patch, combined with my new patch
>
> "drm/i915: Fix DPMS and suspend interaction for intel_panel.c"
>
> all known backlight problems should be fixed.

Btw, can you repost that one as a new email (and cc keithp too)? I
think it got hidden in the other thread by different subject line.

Jesse, did you take a look at that one? It was in the thread with a
subject like "[PATCH] fix backlight brightness on intel LVDS panel
after reopening lid".

Search for

When suspending intel_panel_disable_backlight() is never called,
but intel_panel_enable_backlight() is called at resume. With the
effect that if the brightness was ever changed after screen
blanking, the wrong brightness gets restored at resume time.

in your mailbox.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/