Re: [PATCH 0/6] enable writing to /proc/pid/mem

From: Al Viro
Date: Tue Mar 08 2011 - 21:33:36 EST


On Tue, Mar 08, 2011 at 09:15:25PM -0500, Stephen Wilson wrote:

> I think we could also remove the intermediate copy in both mem_read() and
> mem_write() as well, but I think such optimizations could be left for
> follow on patches.

How? We do copy_.._user() in there; it can trigger page faults and
that's not something you want while holding mmap_sem on some mm.
Looks like a deadlock country... So we can't do that from inside
access_process_vm() or its analogs, which means buffering in caller.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/