Re: [PATCH] mm: skip zombie in OOM-killer

[KOSAKI Motohiro]

> On Sun, 6 Mar 2011, KOSAKI Motohiro wrote:
> 
> > > When we check that task has flag TIF_MEMDIE, we forgot check that
> > > it has mm. A task may be zombie and a parent may wait a memor.
> > > 
> > > v2: Check that task doesn't have mm one time and skip it immediately
> > > 
> > > Signed-off-by: Andrey Vagin <avagin@xxxxxxxxxx>
> > 
> > This seems incorrect. Do you have a reprodusable testcasae?
> > Your patch only care thread group leader state, but current code
> > care all thread in the process. Please look at oom_badness() and 
> > find_lock_task_mm(). 
> > 
> 
> That's all irrelevant, the test for TIF_MEMDIE specifically makes the oom 
> killer a complete no-op when an eligible task is found to have been oom 
> killed to prevent needlessly killing additional tasks.  oom_badness() and 
> find_lock_task_mm() have nothing to do with that check to return 
> ERR_PTR(-1UL) from select_bad_process().

I don't understand you think which task is eligible and unnecessary.
But, Look! Andrey is not talking about zombie process case. But, this v2
patch have factored out other tasks too. This IS the problem. No need
unrelated talk.

> 
> Andrey is patching the case where an eligible TIF_MEMDIE process is found 
> but it has already detached its ->mm.  In combination with the patch 
> posted to linux-mm, oom: prevent unnecessary oom kills or kernel panics, 
> which makes select_bad_process() iterate over all threads, it is an 
> effective solution.

Guys, It was alread NAKed. I've already talk kind explanation. Why do
you bother to look actual code. Why do you continue to talk funny your
dream?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/