Re: [PATCH] pidns: Make pid_max per namespace

From: Andrew Morton
Date: Mon Mar 07 2011 - 18:59:18 EST


On Thu, 03 Mar 2011 11:39:17 +0300
Pavel Emelyanov <xemul@xxxxxxxxxxxxx> wrote:

> Rationale:
>
> On x86_64 with big ram people running containers set pid_max on host to
> large values to be able to launch more containers. At the same time
> containers running 32-bit software experience problems with large pids - ps
> calls readdir/stat on proc entries and inode's i_ino happen to be too big
> for the 32-bit API.
>
> Thus, the ability to limit the pid value inside container is required.
>

This is a behavioural change, isn't it? In current kernels a write to
/proc/sys/kernel/pid_max will change the max pid on all processes.
After this change, that write will only affect processes in the current
namespace. Anyone who was depending on the old behaviour might run
into problems?

Also: documentation. Documentation/sysctl/kernel.txt would like an
update. And perhaps also the pidns documentation which we forgot to
create :(


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/