Re: [PATCH 11/21] staging: ft1000: Fix coding style inft1000_usb_transmit_complete function.

From: Dan Carpenter
Date: Mon Mar 07 2011 - 10:57:33 EST


On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote:
> - if (urb->status)
> - printk("%s: TX status %d\n", ft1000dev->net->name, urb->status);
> + if (urb->status)
> + DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status);
>

Why did you change the printk() to a DEBUG()? That's a behavior change,
and it should have been mentioned in the commit message.

regards,
dan carpenter

> - netif_wake_queue(ft1000dev->net);
> + netif_wake_queue(ft1000dev->net);
>
> //DEBUG("Return from ft1000_usb_transmit_complete\n");
> }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/