Re: [PATCHv2 11/24] sys_swapon: do only cleanup in the cleanupblocks

[KAMEZAWA Hiroyuki]

On Sat,  5 Mar 2011 13:42:12 -0300
Cesar Eduardo Barros <cesarb@xxxxxxxxxx> wrote:

> The only way error is 0 in the cleanup blocks is when the function is
> returning successfully. In this case, the cleanup blocks were setting
> S_SWAPFILE in the S_ISREG case. But this is not a cleanup.
> 
> Move the setting of S_SWAPFILE to just before the "goto out;" to make
> this more clear. At this point, we do not need to test for inode because
> it will never be NULL.
> 
> Signed-off-by: Cesar Eduardo Barros <cesarb@xxxxxxxxxx>
> Tested-by: Eric B Munson <emunson@xxxxxxxxx>
> Acked-by: Eric B Munson <emunson@xxxxxxxxx>

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/