Re: [PATCH 1/4] scatterlist: new helper functions

From: FUJITA Tomonori
Date: Sun Mar 06 2011 - 02:30:00 EST


On Fri, 4 Mar 2011 06:16:50 +0200
Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:

> While developing memstick driver for legacy memsticks
> I found the need in few helpers that I think should be
> in common scatterlist library
>
> The functions that were added:
>
> * sg_nents/sg_total_len - iterate over scatterlist to figure
> out total length of memory it covers / number of entries.

You should invent a data structure per I/O request, something like
msb_request structure. Then you can store nents and total_len in
that.

That's what block subsystems and drivers do. I took a look at your
driver but I can't see why your driver can't do the same.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/