Re: [PATCHv2 23/24] sys_swapoff: change order to match sys_swapon

From: Pekka Enberg
Date: Sat Mar 05 2011 - 12:21:45 EST


On Sat, Mar 5, 2011 at 6:42 PM, Cesar Eduardo Barros <cesarb@xxxxxxxxxx> wrote:
> The block in sys_swapon which does the final adjustments to the
> swap_info_struct and to swap_list is the same as the block which
> re-inserts it again at sys_swapoff on failure of try_to_unuse(), except
> for the order of the operations within the lock. Since the order should
> not matter, arbitrarily change sys_swapoff to match sys_swapon, in
> preparation to making both share the same code.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@xxxxxxxxxx>
> Tested-by: Eric B Munson <emunson@xxxxxxxxx>
> Acked-by: Eric B Munson <emunson@xxxxxxxxx>

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/